build_index with defaults
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
whitead
reviewed
Sep 17, 2024
| ) -> SearchIndex: | ||
| """Build a PaperQA search index, this will also happen automatically upon using `ask`.""" | ||
| settings = get_settings(settings) | ||
| if index_name == "default": |
There was a problem hiding this comment.
should this check for None too?
There was a problem hiding this comment.
I was letting None be handled by the wrapped function get_directory_index. I can do this better to make it clear
There was a problem hiding this comment.
Just pushed a change to DRY it up with get_directory_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it easier to use